Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize resolution of nested definitions everywhere #499

Merged
merged 1 commit into from Jun 4, 2017

Conversation

@mnapoli
Copy link
Member

@mnapoli mnapoli commented Jun 4, 2017

Fix #498 and #488

In PHP-DI 5, definitions could be nested in some places (e.g. use a get() in an object definition, etc.). However it did not behave everywhere the same, for example it didn't work for sub-definitions in arrays.

Now in PHP-DI 6 all nested definitions will all be recognized and resolved correctly everywhere. Since #494 (compiled container) performance will not be affected so we can implement a more robust behavior.

@mnapoli mnapoli added this to the 6.0 milestone Jun 4, 2017
@mnapoli mnapoli force-pushed the standardize-nested-definitions branch from 62ca196 to 85c99a6 Jun 4, 2017
…here

In PHP-DI 5, definitions could be nested in some places (e.g. use a get() in an object definition, etc.). However it did not behave everywhere the same, for example it didn't work for sub-definitions in arrays.

Now in PHP-DI 6 all nested definitions will all be recognized and resolved correctly everywhere. Since #494 (compiled container) performance will not be affected so we can implement a more robust behavior.
@mnapoli mnapoli force-pushed the standardize-nested-definitions branch from d5eec22 to c059f67 Jun 4, 2017
@mnapoli mnapoli merged commit d7966f9 into master Jun 4, 2017
5 of 6 checks passed
5 of 6 checks passed
Scrutinizer Created
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/styleci/push The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 94.996%
Details
@mnapoli mnapoli deleted the standardize-nested-definitions branch Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant