Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upcontainer entries debug #505
Conversation
juliangut
added some commits
Jun 9, 2017
mnapoli
reviewed
Jun 10, 2017
Thanks! I have written a few comments inline, also could you add a changelog entry in the 6.0 section?
| $this->assertEquals('foo', $container->debugEntry('string')); | ||
| $this->assertEquals('string', $container->debugEntry('entry')); | ||
| $this->assertEquals('stdClass', $container->debugEntry('object')); | ||
| } |
This comment has been minimized.
This comment has been minimized.
mnapoli
Jun 10, 2017
Member
This test is ContainerGetTest.php and it's supposed to test the get() method.
I think it would make more sense to move those 2 new tests into a new test class in IntegrationTest (instead of UnitTest) that would test the debug features, i.e. DebugTest ?
| * | ||
| * @return array | ||
| */ | ||
| public function getKnownEntryNames() |
This comment has been minimized.
This comment has been minimized.
mnapoli
Jun 10, 2017
Member
You can add the array return type here and remove the same line that is in the phpdoc (PHP 7 FTW ^^)
This comment has been minimized.
This comment has been minimized.
juliangut
Jun 10, 2017
Contributor
I think code base must be reviewed on missing type hinting hunt, for example on Container::has
This comment has been minimized.
This comment has been minimized.
mnapoli
Jun 11, 2017
Member
I cannot add it for has() and get() because those are defined in PSR-11 unfortunately.
| * | ||
| * @return string | ||
| */ | ||
| public function debugEntry($name) |
This comment has been minimized.
This comment has been minimized.
| return is_object($entry) ? get_class($entry) : gettype($entry); | ||
| } | ||
| throw new InvalidArgumentException("No entry or class found for '$name'"); |
This comment has been minimized.
This comment has been minimized.
mnapoli
Jun 10, 2017
Member
You could throw a NotFound exception? (it wouldn't be a huge difference but since the exception exists let's use it)
mnapoli
added
the
enhancement
label
Jun 10, 2017
mnapoli
added this to the 6.0 milestone
Jun 10, 2017
juliangut
added some commits
Jun 10, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
mnapoli
merged commit 6b55493
into
PHP-DI:master
Jun 11, 2017
juliangut
deleted the
juliangut:container-debug
branch
Jun 11, 2017
added a commit
that referenced
this pull request
Feb 3, 2018
juliangut commentedJun 9, 2017
covers container entries debug dumper as per comment on #152