New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for variadic arguments #624

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@tssge

tssge commented Sep 6, 2018

This closes #619

This pull request is probably missing a lot of things, as I am not completely familiar with PHP-DI source yet. Please feel free to comment on what I could improve.

These changes pass all tests and a new test was added to support the new behavior.

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Sep 18, 2018

Member

You seem to have errors in code formatting (https://github.com/PHP-DI/PHP-DI/pull/624/checks). Could you fix them? And you will probably need to merge master in your branch because of an update in Symfony's coding style.

Member

mnapoli commented Sep 18, 2018

You seem to have errors in code formatting (https://github.com/PHP-DI/PHP-DI/pull/624/checks). Could you fix them? And you will probably need to merge master in your branch because of an update in Symfony's coding style.

@mnapoli mnapoli added the enhancement label Sep 18, 2018

tssge added some commits Sep 6, 2018

Add support for variadic arguments
This makes ParameterResolver resolve variadic arguments correctly
Fix test
Forgot to build container
Sigh
Fix the test values index, I'm blind
@tssge

This comment has been minimized.

Show comment
Hide comment
@tssge

tssge Sep 18, 2018

Thank you for your feedback, I have fixed the formatting now

tssge commented Sep 18, 2018

Thank you for your feedback, I have fixed the formatting now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment