New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify conditions #630

Merged
merged 5 commits into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@omarkdev
Contributor

omarkdev commented Oct 3, 2018

This PR is intended to simplify conditions, either by applying an early return or apply ternary operations in if and else conditions

@mnapoli

👍 some nice changes! I've added a comment inline.

Show outdated Hide outdated src/Definition/Resolver/ParameterResolver.php Outdated

@mnapoli mnapoli added the refactoring label Oct 4, 2018

@omarkdev

This comment has been minimized.

Show comment
Hide comment
@omarkdev

omarkdev Oct 7, 2018

Contributor

Done, @mnapoli, I reversed the change in the file

Contributor

omarkdev commented Oct 7, 2018

Done, @mnapoli, I reversed the change in the file

@omarkdev

This comment has been minimized.

Show comment
Hide comment
@omarkdev

omarkdev Oct 8, 2018

Contributor

@mnapoli I removed the comments by mistake, now I revert the remove of comment

Contributor

omarkdev commented Oct 8, 2018

@mnapoli I removed the comments by mistake, now I revert the remove of comment

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Oct 8, 2018

Member

Thanks

Member

mnapoli commented Oct 8, 2018

Thanks

@mnapoli mnapoli merged commit 66ecb4f into PHP-DI:master Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment