New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correctly phpDocs from Container #632

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@omarkdev
Contributor

omarkdev commented Oct 8, 2018

Looking in Container class I noticed the class has some errors phpDocs annotations, this PR has the intention to solve this errors.

@@ -120,6 +120,7 @@ public function __construct(
*
* @throws DependencyException Error while resolving the entry.
* @throws NotFoundException No entry found for the given name.
* @throws InvalidDefinition

This comment has been minimized.

@mnapoli

mnapoli Oct 8, 2018

Member

Where is this exception thrown in the method?

@mnapoli

mnapoli Oct 8, 2018

Member

Where is this exception thrown in the method?

@@ -230,7 +234,7 @@ public function has($name)
*
* @param object $instance Object to perform injection upon
* @throws InvalidArgumentException
* @throws DependencyException Error while injecting dependencies
* @throws InvalidDefinition

This comment has been minimized.

@mnapoli

mnapoli Oct 8, 2018

Member

Could you explain this change?

@mnapoli

mnapoli Oct 8, 2018

Member

Could you explain this change?

@@ -311,6 +318,7 @@ public function getKnownEntryNames() : array
*
* @param string $name Entry name
*
* @return string

This comment has been minimized.

@mnapoli

mnapoli Oct 8, 2018

Member

This duplicates information that already exists in the code, please remove it as well as similar changes below.

@mnapoli

mnapoli Oct 8, 2018

Member

This duplicates information that already exists in the code, please remove it as well as similar changes below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment