Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen APCu check for SourceCache #661

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@falkenhawk
Copy link

commented May 31, 2019

Use sourceCache if isSupported check passes, otherwise proceed without cache and do not throw an exception

  • so that php-di does not break if there is any problem with apcu - instead of having to wrap ContainerBuilder::build() with try...catch block

[from ovos#3]

Use sourceCache if isSupported check passes, otherwise proceed withou…
…t cache and do not throw an exception

- so that php-di does not break if there is any problem with apcu - instead of having to wrap ContainerBuilder::build() with try...catch block

@mnapoli mnapoli added the enhancement label Jun 1, 2019

@mnapoli

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Thank you, I am afraid about this change that some people will think they use APCu, but they actually don't.

Could you explain the use case behind this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.