Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target evenement 3.0 a long side 2.0 and 1.0 #385

Merged
merged 2 commits into from Feb 26, 2019

Conversation

Projects
None yet
3 participants
@WyriHaximus
Copy link
Contributor

commented Jul 23, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs none
License MIT

What's in this PR?

Support for evenement 3.0

Why?

Evenement 3.0 packs a set of performance improvements for PHP 7 users.

BC Breaks/Deprecations

None, although I haven't ran your test suite locally, this is a github.com online edit and PR.

To Do

  • Create tests (no need for tests)
@jens1o

This comment has been minimized.

Copy link
Member

commented Jul 24, 2017

First of all, thanks for the pr.
I'll check this out, thanks for the suggestion. :)

@WyriHaximus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2017

No problem at all, took over maintenance of evenement a few weeks ago and now going through the most used packages using to with PR's like these :).

@loga4

This comment has been minimized.

Copy link

commented Feb 25, 2019

can you merge this PR ?

@jens1o

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

Woah, I'm really bad at resolving to-dos. Sorry.

@jens1o jens1o merged commit f9cc3d0 into PHP-FFMpeg:master Feb 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jens1o

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

Thanks again!

@WyriHaximus

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

@jens1o glad to see this is coming through and you're welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.