Conversation
Tests will often enough need access to the PHPCS version on which the tests are being run. This adds a `$phpcsVersion` property to the `PHPCSUtils\TestUtils\UtilityMethodTestCase` class to make that version number easily and always available. **Note**: if the PHPCS version is needed within a data provider method for a test, `Helper::getVersion()` still needs to be used as the data providers are run before the `setUpBeforeClass()` type methods.
…erty ... in all relevant places in the existing tests.
jrfnl
force-pushed
the
testutils/utilitymethodtestcase-add-phpcsversion-property
branch
from
87d56ce to
788a52b
Compare
jrfnl
deleted the
testutils/utilitymethodtestcase-add-phpcsversion-property
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestUtils\UtilityMethodTestCase: add new $phpcsVersion property
Tests will often enough need access to the PHPCS version on which the tests are being run.
This adds a
$phpcsVersionproperty to thePHPCSUtils\TestUtils\UtilityMethodTestCaseclass to make that version number easily and always available.Note: if the PHPCS version is needed within a data provider method for a test,
Helper::getVersion()still needs to be used as the data providers are run before thesetUpBeforeClass()type methods.Tests: implement use of the UtilityMethodTestCase::$phpcsVersion property
... in all relevant places in the existing tests.