BCFile/ObjectDeclarations::getDeclarationName(): compatibility with PHPCS 4.x#110
Merged
jrfnl merged 1 commit intoMar 18, 2020
Merged
Conversation
…HPCS 4.x PHPCS removes support for the JS and CSS tokenizers, which includes removing the `File::$tokenizerType` property. This commit makes it so the `BCFile::getDeclarationName()` and the `ObjectDeclarations::getDeclarationName()` methods won't throw an error for the property not existing. And just to be clear: while PHPCSUtils in combination with PHPCS 2.x and 3.x _may_ incidentally support JS/CSS, in combination with PHPCS 4.x, JS/CSS will explicitly not be supported. Ref: squizlabs/PHP_CodeSniffer@ea52e7b
jrfnl
deleted the
feature/getdeclarationname-compatibility-with-phpcs-4.x
branch
March 18, 2020 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPCS removes support for the JS and CSS tokenizers, which includes removing the
File::$tokenizerTypeproperty.This commit makes it so the
BCFile::getDeclarationName()and theObjectDeclarations::getDeclarationName()methods won't throw an error for the property not existing.And just to be clear: while PHPCSUtils in combination with PHPCS 2.x and 3.x may incidentally support JS/CSS, in combination with PHPCS 4.x, JS/CSS will explicitly not be supported.
Ref: squizlabs/PHP_CodeSniffer@ea52e7b