BackCompat\Helper: add getEncoding()helper method#118
Merged
Conversation
... to retrieve the file encoding a project supposedly uses. No check is done to see if the `encoding` set is actually correct for the files presented to PHPCS. In PHPCS, the `encoding` can be set via `--config-set` or `--encoding` from the command-line or via a custom ruleset like `<arg name="encoding" value="utf-8"/>`. The default encoding encoding used by PHPCS changed between PHPCS 2.x (`iso-8859-1`) and 3.x `utf-8`. Using the `utf-8` file encoding is strongly advised for all PHP projects. Includes minimal unit tests.
…getEncoding()` method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BackCompat\Helper: add
getEncoding()helper method... to retrieve the file encoding a project supposedly uses. No check is done to see if the
encodingset is actually correct for the files presented to PHPCS.In PHPCS, the
encodingcan be set via--config-setor--encodingfrom the command-line or via a custom ruleset like<arg name="encoding" value="utf-8"/>.The default encoding encoding used by PHPCS changed between PHPCS 2.x (
iso-8859-1) and 3.xutf-8.Using the
utf-8file encoding is strongly advised for all PHP projects.Includes minimal unit tests.
Orthography::isLastCharPunctuation(): implement use of the
Helper::getEncoding()method