Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Minor fixes for home page content #121

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Docs: Minor fixes for home page content #121

merged 1 commit into from
Mar 29, 2020

Conversation

GaryJones
Copy link
Contributor

Checked with a Grammarly and myself :-)

@jrfnl jrfnl added this to the 1.0.0 milestone Mar 28, 2020
jrfnl
jrfnl reviewed Mar 28, 2020
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He Gary, thanks a lot for this!

I've left a few comments/questions in-line. Other than that, this same text is also used in the README.md, so that will probably also need updating.

docs/index.html Outdated Show resolved Hide resolved
docs/index.html Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
@GaryJones
Copy link
Contributor Author

Feedback incorporated, and README updated.

jrfnl
jrfnl reviewed Mar 29, 2020
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gary for making those changes and updating the Readme as well. I've found just a couple of very minor issues still. If you like, I can fix those up myself ?

docs/index.html Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
docs/index.html Show resolved Hide resolved
@GaryJones
Copy link
Contributor Author

5 bits of feedback added in, along with adding hyphens to two instances of "Composer based" in the README table of contents.

@GaryJones GaryJones requested a review from jrfnl March 29, 2020 17:21
@jrfnl jrfnl merged commit af4a0a7 into PHPCSStandards:develop Mar 29, 2020
@jrfnl
Copy link
Member

jrfnl commented Mar 29, 2020 •
edited
Loading

Thank you so much for this @GaryJones ! Please have this badge for being the first (external) contributor to this repo: 🛡️

@jrfnl jrfnl modified the milestones: 1.0.0, 1.0.0-alpha3 May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl Awaiting requested review from jrfnl

Assignees
No one assigned
Labels
Type: documentation
Projects
None yet
Milestone
1.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
2 participants
@GaryJones @jrfnl