Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections::namespacedNameTokens(): support the PHP 8 identifier name tokens #205

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 13, 2020

Includes adjusted unit test.

This change automatically adds compatibility with the PHP 8.0 identifier name tokens to the following methods:

  • ControlStructures::getCaughtExceptions()
  • FunctionDeclarations::isPHPDoubleUnderscoreMethod() (via ObjectDeclarations::findExtendedClassName())
  • ObjectDeclarations::findNames()
  • ObjectDeclarations::findExtendedClassName()
  • ObjectDeclarations::findImplementedInterfaceNames()
  • ObjectDeclarations::findExtendedInterfaceNames()
  • Operators::isReference()

Includes adding additional unit tests for these methods in those cases where any of the identifier name types (fully qualified, partially qualified, namespace relative or unqualified) wasn't covered yet.

…e tokens

Includes adjusted unit test.

This change automatically adds compatibility with the PHP 8.0 identifier name tokens to the following methods:
* `ControlStructures::getCaughtExceptions()`
* `FunctionDeclarations::isPHPDoubleUnderscoreMethod()` (via `ObjectDeclarations::findExtendedClassName()`)
* `ObjectDeclarations::findNames()`
* `ObjectDeclarations::findExtendedClassName()`
* `ObjectDeclarations::findImplementedInterfaceNames()`
* `ObjectDeclarations::findExtendedInterfaceNames()`
* `Operators::isReference()`

Includes adding additional unit tests for these methods in those cases where any of the identifier name types (fully qualified, partially qualified, namespace relative or unqualified) wasn't covered yet.
@jrfnl jrfnl added this to the 1.0.0-alpha4 milestone Sep 13, 2020
@jrfnl jrfnl merged commit 2786537 into develop Sep 13, 2020
@jrfnl jrfnl deleted the php-8.0/collections-namespacednametokens-support-identifier-name-tokens branch September 13, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant