Namespaces::getType(): compatibility with the PHP 8 identifier name tokenization#209
Merged
jrfnl merged 1 commit intoSep 13, 2020
Conversation
…okenization When the PHP 8 identifier name tokenization is used, the `Namespace::getType()` method basically becomes redundant as the `T_NAMESPACE` token when used as an operator will no longer exist, except when there is a PHP 8 parse error. The `Namespaces::getType()` method has been adjusted to allow for all the situations which were previously already accounted for. The associated tests have been adjusted to skip the test cases involving namespace keywords used an operator in a non-parse error situation when PHP 8 identifier name tokenization is used, as those tests no longer apply.
jrfnl
deleted the
php-8.0/namespaces-gettype-identifier-name-compatibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the PHP 8 identifier name tokenization is used, the
Namespace::getType()method basically becomes redundant as theT_NAMESPACEtoken when used as an operator will no longer exist, except when there is a PHP 8 parse error.The
Namespaces::getType()method has been adjusted to allow for all the situations which were previously already accounted for.The associated tests have been adjusted to skip the test cases involving namespace keywords used an operator in a non-parse error situation when PHP 8 identifier name tokenization is used, as those tests no longer apply.