PassedParameters::[has|get]Parameters(): add new, optional $isShortArray parameter
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray` parameter This adds a new, optional `$isShortArray` parameter to the `PassedParameters::hasParameters()` and the `PassedParameters::getParameters()` methods to allow for skipping the "is short array" check for passed square brackets when the value is set to `true`. It is HIGHLY DISCOURAGED to ever use to this parameter and this parameter should only ever be used with extreme care and forethought! The reason to add this parameter is that it will allow for the "is short array or short list" check to use the `PassedParameters` functionality without throwing execution into an infinite loop. Most likely, the use in that check will be the only legitimate use of the parameter. Includes dedicated unit tests for documenting the behaviour of the class when the `$isShortArray` parameter is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new, optional
$isShortArrayparameter to thePassedParameters::hasParameters()and thePassedParameters::getParameters()methods to allow for skipping the "is short array" check for passed square brackets when the value is set totrue.It is HIGHLY DISCOURAGED to ever use this parameter and this parameter should only ever be used with extreme care and forethought!
The reason to add this parameter is that it will allow for the "is short array or short list" check to use the
PassedParametersfunctionality without throwing execution into an infinite loop.Most likely, the use in that check will be the only legitimate use of the parameter.
Includes dedicated unit tests for documenting the behaviour of the class when the
$isShortArrayparameter is used.