PHP 8.1 | Numbers: add support for explicit octal notation #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add support for the explicit octal notation using a `0o`/`0O` prefix as supported in PHP as of PHP 8.1. The only method which needed adjusting was the `Numbers::getCompleteNumber()` method, which now backfills the tokenization when needed. For the `Numbers::isOctalInt()` method, a small tweak to the regex was all that was needed. As for the `Numbers::getDecimalValue()` method: this already handled the conversion correctly due to the use of the PHP native `octdec()` function. From the RFC: > Surprisingly PHP already has support for this notation when using the `octdec()` and `base_convert()` functions. Includes adding unit tests to safeguard support in all relevant methods in the class. Refs: * https://wiki.php.net/rfc/explicit_octal_notation * php/php-src#6360 * squizlabs/PHP_CodeSniffer#3481 * squizlabs/PHP_CodeSniffer#3552
|
This PR depends on the upstream PR squizlabs/PHP_CodeSniffer#3552, which needs to be merged first. |
|
The upstream PR has been merged 🎉 |
jrfnl
deleted the
php-8.1/numbers-add-support-for-explicit-octal-notation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for the explicit octal notation using a
0o/0Oprefix as supported in PHP as of PHP 8.1.The only method which needed adjusting was the
Numbers::getCompleteNumber()method, which now backfills the tokenization when needed.For the
Numbers::isOctalInt()method, a small tweak to the regex was all that was needed.As for the
Numbers::getDecimalValue()method: this already handled the conversion correctly due to the use of the PHP nativeoctdec()function.From the RFC:
Includes adding unit tests to safeguard support in all relevant methods in the class.
Refs: