FunctionDeclarations::getParameters(): allow for readonly properties without visibility #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without visibility Follow up on PR 363 which was included in PHPCSUtils 1.0.0-alpha4. Turns out that constructor property promotion also allows for declaring properties with the `readonly` keyword, but without explicit visibility set. See: https://3v4l.org/nli62 Readonly properties without explicit visibility are already handled correctly in the `Variables::getMemberProperties()` method, but were not handled correctly in the `FunctionDeclarations::getParameters()` method. Fixed now. Includes updated documentation and a unit test. A similar PR has been pulled upstream squizlabs/PHP_CodeSniffer 3801
jrfnl
deleted the
utils/functiondeclarations-getparameters-improve-readonly-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on PR #363 which was included in PHPCSUtils 1.0.0-alpha4.
Turns out that constructor property promotion also allows for declaring properties with the
readonlykeyword, but without explicit visibility set. See: https://3v4l.org/nli62Readonly properties without explicit visibility are already handled correctly in the
Variables::getMemberProperties()method, but were not handled correctly in theFunctionDeclarations::getParameters()method.Fixed now.
Includes updated documentation and a unit test.
A similar PR has been pulled upstream squizlabs/PHP_CodeSniffer#3801