✨ New FileInfo utility class - #572
Merged
Merged
Conversation
andrewnicols
suggested changes
Mar 23, 2024
andrewnicols
left a comment
andrewnicols
left a comment
There was a problem hiding this comment.
Hi @jrfnl,
This change looks good to me and I believe you cover all of the cases I can think of.
The only thing I have to note is a typo on recognized in the test docblocks reocgnized.
jrfnl
force-pushed
the
utils/new-fileinfo-class
branch
from
March 24, 2024 22:15
343de4f to
45581b5
Compare
Member
Author
|
@andrewnicols Thanks for catching that typo! I've fixed it up in the existing commit now. |
andrewnicols
approved these changes
Mar 24, 2024
jrfnl
force-pushed
the
utils/new-fileinfo-class
branch
from
May 10, 2024 05:50
45581b5 to
8f6c2f8
Compare
This new class initially contains the following methods: * `hasByteOrderMark(File $phpcsFile): string|false` to determine whether a file starts with a byte order mark and if so, which type of byte order mark. * `hasSheBang(File $phpcsFile): bool` to determine whether a file starts with a shebang line. Includes tests.
jrfnl
force-pushed
the
utils/new-fileinfo-class
branch
from
May 20, 2024 18:05
8f6c2f8 to
c41ab20
Compare
Member
Author
|
Rebased without changes. Merging once the build passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new class initially contains the following methods:
hasByteOrderMark(File $phpcsFile): string|falseto determine whether a file starts with a byte order mark and if so, which type of byte order mark.hasSheBang(File $phpcsFile): boolto determine whether a file starts with a shebang line.Includes tests.