Utils\Numbers: replace $unsupportedPHPCSVersions with UNSUPPORTED_VERSION
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PHPCS_VERSION` As the fix for the broken backfill in PHPCS 3.5.3 was released in PHPCS 3.5.4, there is only one PHPCS version which is unsupported. This negates the need for an array, making it possible to use a class constant instead which should be less risky as it cannot be overloaded. Includes adjusting all places in the code base which were using the property to use the constant instead.
jrfnl
force-pushed
the
feature/numbers-change-property-to-constant
branch
from
3456a1c to
379013f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the fix for the broken backfill in PHPCS 3.5.3 was released in PHPCS 3.5.4, there is only one PHPCS version which is unsupported.
This negates the need for an array, making it possible to use a class constant instead which should be less risky as it cannot be overloaded.
Includes adjusting all places in the code base which were using the property to use the constant instead.