Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic/LowerCaseType: add support for examining DNF types #478

Merged
merged 1 commit into from
May 6, 2024
Merged

Generic/LowerCaseType: add support for examining DNF types #478

merged 1 commit into from
May 6, 2024

Commits on May 6, 2024

  1. Generic/LowerCaseType: add support for examining DNF types 

    The `Generic.PHP.LowerCaseType` sniff needs to be updated to also handle non-lowercase types which are part of a DNF type declaration.

This commit updates the `processUnionType()` method to not only examine union types, but to examine all multi-token types and to do so in a slightly more performant manner and calls that method now for all multi-token type declarations.

Note: The method name now doesn't properly cover the functionality anymore, however, renaming the method would be a breaking change as the class is not `final` and the method not `private`.

Includes unit tests.

Related to 105

Closes 105
    @jrfnl
    jrfnl committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9bf4e15 View commit details
    Browse the repository at this point in the history