From 49a4e7b12a0ceb1b74bc493624f337a1c5464925 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Mon, 21 Jun 2021 21:56:30 +0200 Subject: [PATCH] GH Actions: set error reporting to E_ALL Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`. For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown. --- .github/workflows/integrationtest.yml | 1 + .github/workflows/quicktest.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/integrationtest.yml b/.github/workflows/integrationtest.yml index 0a80ba63..3d847f55 100644 --- a/.github/workflows/integrationtest.yml +++ b/.github/workflows/integrationtest.yml @@ -140,6 +140,7 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php }} + ini-values: error_reporting=E_ALL, display_errors=On coverage: none - name: 'Composer: set PHPCS version for tests' diff --git a/.github/workflows/quicktest.yml b/.github/workflows/quicktest.yml index 5fc76c95..f6155942 100644 --- a/.github/workflows/quicktest.yml +++ b/.github/workflows/quicktest.yml @@ -45,6 +45,7 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php }} + ini-values: error_reporting=E_ALL, display_errors=On coverage: none - name: 'Composer: set PHPCS version for tests'