Two small suggestions #1

merged 2 commits into from Sep 3, 2012


None yet

2 participants



two minor suggestions:

  • use ctype_xdigit() instead of custom regex. More a cosmetic improvement, but since it is already there, once can use it. It also only allows strings (ctype_xdigit(123) === false), preg_match is more careless.
  • if you get an error message and an error number, pass it (via the exception) through to the caller.
@PHPGangsta PHPGangsta merged commit 53d531e into PHPGangsta:master Sep 3, 2012

Thanks Jannik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment