New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.json: add dependency on the PHP "filter" extension. #1301

Merged
merged 1 commit into from Dec 22, 2017

Conversation

Projects
None yet
2 participants
@orlitzky
Contributor

orlitzky commented Dec 21, 2017

Many of the PHP extensions used by PHPMailer are optional, in one of
two senses. Either there is a fallback if the extension is not
present, or the use of the extension is avoidable entirely. For
example, there is a fallback parser if "imap_rfc822_parse_adrlist" is
not available, and OpenSSL is not needed unless encryption is used;
therefore neither are hard dependencies.

The filter extension, on the other hand, is unavoidable. It is used
unconditionally, with no fallbacks, in (for example) the "isValidHost"
function. This commit adds "ext-filter" to composer.json, to document
the dependency and to help out composer users.

Closes: #1298

composer.json: add dependency on the PHP "filter" extension.
Many of the PHP extensions used by PHPMailer are optional, in one of
two senses. Either there is a fallback if the extension is not
present, or the use of the extension is avoidable entirely. For
example, there is a fallback parser if "imap_rfc822_parse_adrlist" is
not available, and OpenSSL is not needed unless encryption is used;
therefore neither are hard dependencies.

The filter extension, on the other hand, is unavoidable. It is used
unconditionally, with no fallbacks, in (for example) the "isValidHost"
function. This commit adds "ext-filter" to composer.json, to document
the dependency and to help out composer users.

Closes: #1298

@Synchro Synchro merged commit c8613a4 into PHPMailer:master Dec 22, 2017

@Synchro

This comment has been minimized.

Member

Synchro commented Dec 22, 2017

Thanks for your research into this, and the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment