Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Name Parsing fails if document generated by a non-english word version #1434

Merged
merged 1 commit into from Dec 28, 2018
Merged

Style Name Parsing fails if document generated by a non-english word version #1434

merged 1 commit into from Dec 28, 2018

Conversation

begnini
Copy link
Contributor

@begnini begnini commented Jul 17, 2018

Description

Depending on the language of the word installation, the styleId is different.
e.g.

  • en: Heading1
  • fr: Titre1
  • pt: Titulo1
  • de: Übershrift1
  • ...
    Because of this the parser fails to parse the Styles
    The solution is to use the <w:name /> instead

Fixes #1431

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@troosan troosan added this to the v0.16.0 milestone Dec 27, 2018
@troosan troosan changed the title Improving Style Parsing - handling Heading style Style Name Parsing fails if document generated by a non-english word version Dec 28, 2018
@troosan troosan merged commit f5e3807 into PHPOffice:develop Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants