Skip to content

Simplified CellTest and added a helper method for styles #4734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleibman merged 3 commits into from
Dec 4, 2025
+41 −54
Merged

Simplified CellTest and added a helper method for styles #4734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
873aa64
Simplified CellTest and added a helper method for styles
zhukoff74 Dec 3, 2025
49479a0
replace with
zhukoff74 Dec 3, 2025
c1be7a5
Strengthen One Test
oleibman Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 38 additions & 51 deletions tests/PhpSpreadsheetTests/Cell/CellTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,16 @@ protected function tearDown(): void
}
}

private function createSolidFillStyle(string $color): Style
{
$style = new Style(false, true);
$style->getFill()
->setFillType(Fill::FILL_SOLID)
->getStartColor()->setARGB($color);

return $style;
}

public function testSetValueBinderOverride(): void
{
$value = '12.5%';
Expand Down Expand Up @@ -105,9 +115,10 @@ public function testInvalidIsoDateSetValueExplicit(): void
}

#[DataProvider('providerSetValueExplicitException')]
public function testSetValueExplicitException(mixed $value, string $dataType): void
public function testSetValueExplicitException(mixed $value, string $dataType, string $message): void
{
$this->expectException(Exception::class);
$this->expectExceptionMessage($message);

$this->spreadsheet = new Spreadsheet();
$cell = $this->spreadsheet->getActiveSheet()->getCell('A1');
Expand All @@ -130,12 +141,11 @@ public function testNoChangeToActiveSheet(): void
$sheet1->setCellValue('D1', 124);
$sheet3->setCellValue('A1', "='Sheet 1'!C1+'Sheet 1'!D1");
$sheet1->setCellValue('A1', "='Sheet 3'!A1");
$cell = 'A1';
$spreadsheet->setActiveSheetIndex(0);
self::assertEquals(0, $spreadsheet->getActiveSheetIndex());
$value = $spreadsheet->getActiveSheet()->getCell($cell)->getCalculatedValue();
self::assertEquals(0, $spreadsheet->getActiveSheetIndex());
self::assertEquals(247, $value);
self::assertSame(0, $spreadsheet->getActiveSheetIndex());
$value = $spreadsheet->getActiveSheet()->getCell('A1')->getCalculatedValue();
self::assertSame(0, $spreadsheet->getActiveSheetIndex());
self::assertSame(247, $value);
$spreadsheet->disconnectWorksheets();
}

Expand Down Expand Up @@ -172,12 +182,9 @@ public function testDestroyCell2(): void
$this->expectException(Exception::class);
$this->expectExceptionMessage('Coordinate no longer exists');
$parent = $cell->getParent();
if ($parent === null) {
self::fail('Unexpected null parent');
} else {
$parent->delete('A1');
$cell->getCoordinate();
}
self::assertNotNull($parent, 'Parent should not be null');
$parent->delete('A1');
$cell->getCoordinate();
}

public function testAppliedStyleWithRange(): void
Expand All @@ -191,56 +198,44 @@ public function testAppliedStyleWithRange(): void
$cellRange = 'A1:A3';
$sheet->getStyle($cellRange)->getFont()->setBold(true);

$yellowStyle = new Style(false, true);
$yellowStyle->getFill()
->setFillType(Fill::FILL_SOLID)
->getStartColor()->setARGB(Color::COLOR_YELLOW);
$greenStyle = new Style(false, true);
$greenStyle->getFill()
->setFillType(Fill::FILL_SOLID)
->getStartColor()->setARGB(Color::COLOR_GREEN);
$redStyle = new Style(false, true);
$redStyle->getFill()
->setFillType(Fill::FILL_SOLID)
->getStartColor()->setARGB(Color::COLOR_RED);
$yellowStyle = $this->createSolidFillStyle(Color::COLOR_YELLOW);
$greenStyle = $this->createSolidFillStyle(Color::COLOR_GREEN);
$redStyle = $this->createSolidFillStyle(Color::COLOR_RED);

$conditionalStyles = [];
$wizardFactory = new Wizard($cellRange);
/** @var Wizard\CellValue $cellWizard */
$cellWizard = $wizardFactory->newRule(Wizard::CELL_VALUE);

$cellWizard->equals(0)
->setStyle($yellowStyle);
$conditionalStyles = [];
$cellWizard->equals(0)->setStyle($yellowStyle);
$conditionalStyles[] = $cellWizard->getConditional();

$cellWizard->greaterThan(0)
->setStyle($greenStyle);
$cellWizard->greaterThan(0)->setStyle($greenStyle);
$conditionalStyles[] = $cellWizard->getConditional();

$cellWizard->lessThan(0)
->setStyle($redStyle);
$cellWizard->lessThan(0)->setStyle($redStyle);
$conditionalStyles[] = $cellWizard->getConditional();

$sheet->getStyle($cellWizard->getCellRange())
->setConditionalStyles($conditionalStyles);

$style = $sheet->getCell('A1')->getAppliedStyle();
self::assertTrue($style->getFont()->getBold());
self::assertEquals($redStyle->getFill()->getFillType(), $style->getFill()->getFillType());
self::assertEquals($redStyle->getFill()->getStartColor()->getARGB(), $style->getFill()->getStartColor()->getARGB());
self::assertSame($redStyle->getFill()->getFillType(), $style->getFill()->getFillType());
self::assertSame($redStyle->getFill()->getStartColor()->getARGB(), $style->getFill()->getStartColor()->getARGB());

$style = $sheet->getCell('A2')->getAppliedStyle();
self::assertTrue($style->getFont()->getBold());
self::assertEquals($yellowStyle->getFill()->getFillType(), $style->getFill()->getFillType());
self::assertEquals(
self::assertSame($yellowStyle->getFill()->getFillType(), $style->getFill()->getFillType());
self::assertSame(
$yellowStyle->getFill()->getStartColor()->getARGB(),
$style->getFill()->getStartColor()->getARGB()
);

$style = $sheet->getCell('A3')->getAppliedStyle();
self::assertTrue($style->getFont()->getBold());
self::assertEquals($greenStyle->getFill()->getFillType(), $style->getFill()->getFillType());
self::assertEquals(
self::assertSame($greenStyle->getFill()->getFillType(), $style->getFill()->getFillType());
self::assertSame(
$greenStyle->getFill()->getStartColor()->getARGB(),
$style->getFill()->getStartColor()->getARGB()
);
Expand All @@ -261,27 +256,19 @@ public function testAppliedStyleSingleCell(string $cellAddress, string $fillStyl
$cellRange = 'A1:C2';
$sheet->getStyle($cellRange)->getFont()->setBold(true);

$yellowStyle = new Style(false, true);
$yellowStyle->getFill()
->setFillType(Fill::FILL_SOLID)
->getStartColor()->setARGB(Color::COLOR_YELLOW);
$redStyle = new Style(false, true);
$redStyle->getFill()
->setFillType(Fill::FILL_SOLID)
->getStartColor()->setARGB(Color::COLOR_RED);
$yellowStyle = $this->createSolidFillStyle(Color::COLOR_YELLOW);
$redStyle = $this->createSolidFillStyle(Color::COLOR_RED);

$conditionalCellRange = 'A1:C1';
$conditionalStyles = [];
$wizardFactory = new Wizard($conditionalCellRange);
/** @var Wizard\CellValue $cellWizard */
$cellWizard = $wizardFactory->newRule(Wizard::CELL_VALUE);

$cellWizard->equals(0)
->setStyle($yellowStyle);
$cellWizard->equals(0)->setStyle($yellowStyle);
$conditionalStyles[] = $cellWizard->getConditional();

$cellWizard->lessThan(0)
->setStyle($redStyle);
$cellWizard->lessThan(0)->setStyle($redStyle);
$conditionalStyles[] = $cellWizard->getConditional();

$sheet->getStyle($cellWizard->getCellRange())
Expand All @@ -290,9 +277,9 @@ public function testAppliedStyleSingleCell(string $cellAddress, string $fillStyl
$style = $sheet->getCell($cellAddress)->getAppliedStyle();

self::assertTrue($style->getFont()->getBold());
self::assertEquals($fillStyle, $style->getFill()->getFillType());
self::assertSame($fillStyle, $style->getFill()->getFillType());
if ($fillStyle === Fill::FILL_SOLID) {
self::assertEquals($fillColor, $style->getFill()->getStartColor()->getARGB());
self::assertSame($fillColor, $style->getFill()->getStartColor()->getARGB());
}
$spreadsheet->disconnectWorksheets();
}
Expand Down
6 changes: 3 additions & 3 deletions tests/data/Cell/SetValueExplicitException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use PhpOffice\PhpSpreadsheet\Cell\DataType;

return [
'invalid numeric' => ['XYZ', DataType::TYPE_NUMERIC],
'invalid array' => [[], DataType::TYPE_STRING],
'invalid unstringable object' => [new DateTime(), DataType::TYPE_INLINE],
'invalid numeric' => ['XYZ', DataType::TYPE_NUMERIC, 'Invalid numeric value'],
'invalid array' => [[], DataType::TYPE_STRING, 'Unable to convert to string'],
'invalid unstringable object' => [new DateTime(), DataType::TYPE_INLINE, 'Unable to convert to string'],
];