Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anonymizable Interfaces to keep track of the anonymization process #2

Merged
merged 4 commits into from Jan 6, 2020

Conversation

@RocKordier
Copy link
Member

RocKordier commented Dec 27, 2019

No description provided.

…s which are independent from the event system
src/Visitor/GraphNavigator.php Outdated Show resolved Hide resolved
src/Visitor/GraphNavigator.php Outdated Show resolved Hide resolved
@@ -74,6 +78,10 @@ private function visitObject($value): void

$this->dispatcher->dispatch(new PostAnonymizeEvent($value));

if ($value instanceof BeenAnonymizedInterface) {
$value->beenAnonymized();

This comment has been minimized.

Copy link
@Baachi

Baachi Dec 29, 2019

Contributor

I like the method names a lot! 👍

Copy link
Contributor

Baachi left a comment

Hey, thanks for this PR!

First of all, I like the method names. But wouldn't it be better to have this as an event subscriber?

@RocKordier

This comment has been minimized.

Copy link
Member Author

RocKordier commented Dec 30, 2019

@Baachi see comments above

@RocKordier RocKordier requested a review from Baachi Jan 2, 2020
src/BeenAnonymizedInterface.php Outdated Show resolved Hide resolved
Baachi and others added 3 commits Jan 6, 2020
@RocKordier RocKordier merged commit 34babaf into master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.