Skip to content

Conversation

@mipapo
Copy link
Contributor

@mipapo mipapo commented Dec 17, 2015

This change will prevent php warnings if the file is not existing anymore.

need to eliminate php warnings
khoaofgod added a commit that referenced this pull request Dec 17, 2015
add file_exists check for file driver delete function
@khoaofgod khoaofgod merged commit cafc8b4 into PHPSocialNetwork:final Dec 17, 2015
@khoaofgod
Copy link
Member

thanks

@koenpunt
Copy link
Contributor

The @ before unlink already silences this warning, so this doubles the overhead.

@mipapo
Copy link
Contributor Author

mipapo commented Dec 21, 2015

Suppressing warnings with an @ is not a good programming style...

@koenpunt
Copy link
Contributor

I didn't say it was, but if you think that's the case, why is the @ still in there?

@koenpunt
Copy link
Contributor

Any other error, except for non existing files, will still be silenced.

@khoaofgod
Copy link
Member

@koenpunt is right, hahaha
The "@" is still there. Should remove the "@" after add file existing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants