Skip to content

PHP 7.4 support #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2020
Merged

PHP 7.4 support #749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c9a578
PHP 7.4 support
Aug 8, 2020
14af03b
Fix PHP 7.0 break due to undefined method.
Aug 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions lib/Phpfastcache/Config/ConfigurationOption.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,24 @@ public function __construct(...$args)
$typeHintGot = \is_object($value) ? \get_class($value) : \gettype($value);
$reflectionMethod = new \ReflectionMethod($this, $method);
$parameter = $reflectionMethod->getParameters()[0] ?? null;
$typeHintExpected = ($parameter instanceof \ReflectionParameter ? ($parameter->getType() === 'object' ? $parameter->getClass() : $parameter->getType()) : 'Unknown type');

throw new PhpfastcacheInvalidConfigurationException(\sprintf(
'Invalid type hint found for "%s", expected "%s" got "%s"',
\lcfirst(\substr($method, 3)),
$typeHintExpected,
$typeHintGot
));
$paraReflectionType = $parameter->getType();
if(method_exists($paraReflectionType, "getName")) {
$typeHintExpected = ($parameter instanceof \ReflectionParameter ? ($paraReflectionType->getName() === 'object' ? $parameter->getClass() : $paraReflectionType->getName()) : 'Unknown type');
throw new PhpfastcacheInvalidConfigurationException(\sprintf(
'Invalid type hint found for "%s", expected "%s" got "%s"',
\lcfirst(\substr($method, 3)),
$typeHintExpected,
$typeHintGot
));
} else {
$typeHintExpected = ($parameter instanceof \ReflectionParameter ? ($paraReflectionType === 'object' ? $parameter->getClass() : $paraReflectionType) : 'Unknown type');
throw new PhpfastcacheInvalidConfigurationException(\sprintf(
'Invalid type hint found for "%s", expected "%s" got "%s"',
\lcfirst(\substr($method, 3)),
$typeHintExpected,
$typeHintGot
));
}
}
}
}
Expand Down Expand Up @@ -447,4 +457,4 @@ public function setCacheSlamsTimeout(int $cacheSlamsTimeout): self
$this->cacheSlamsTimeout = $cacheSlamsTimeout;
return $this;
}
}
}