Speed up shield sync #343
Merged
Speed up shield sync #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JSKitty
previously approved these changes
Apr 16, 2024
There was a problem hiding this comment.
tACK 5c031d1
I tested this back-to-back against another Master instance using the same seed - unfortunately my internet is too slow to see a huge difference, but I can still notice it. Either way, code looks good and makes sense.
Duddino
reviewed
Apr 16, 2024
Duddino
previously approved these changes
Apr 17, 2024
JSKitty
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Do not fetch coinbase and coinstake txs when syncing shield. It's useless since they will never contain shield data.
This simple optimization made my wallet sync 40% faster.