Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] GitHub Pull Request guidelines #69

Merged
merged 1 commit into from
Jan 1, 2023
Merged

[Docs] GitHub Pull Request guidelines #69

merged 1 commit into from
Jan 1, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Dec 30, 2022

To bring order in the midst of our chaos, we now have a neat little template for each PR devs submit, and here's a few reasons it's neat:

  • It's standardised: we can all use a familiar, digestible format.
  • Devs get a breakdown: allowing them to dig in to add/improve the PR without guess-work.
  • Reviewers get a high-level overview: so they know the functionality to expect, and can test + verify.
  • Easier for our LMP team to 'convert' each PR in to a Proposal: making it easier for devs to be rewarded.

GitHub will automatically display this template for all future PRs post this one's merge, so no copy/pasting required, just filling a few areas and pushing.

@JSKitty JSKitty added the Documentation Improvements or additions to documentation label Dec 30, 2022
@JSKitty JSKitty requested review from Liquid369 and Duddino December 30, 2022 20:31
@JSKitty JSKitty self-assigned this Dec 30, 2022
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

I do not see a reason for any changes to this template currently as we will learn what the DAO will like more to assist our proposals

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@JSKitty JSKitty merged commit 729c218 into master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants