Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image CI FIX #78

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Docker image CI FIX #78

merged 4 commits into from
Feb 2, 2023

Conversation

ZOZOTHEHellhound
Copy link

@ZOZOTHEHellhound ZOZOTHEHellhound commented Jan 31, 2023

Abstract

Fixes the issue #77, while also improving the image size. This leads to saving in bandwidth and also enables hosters like me to again autopull the image without it being to big without reason.

What does this PR address?

Fixes failing CI auto builds

What features or improvements were added?

Nothing but reduced image size.

How does this benefit users?

Not the users but the ones hosting an instance, as image pulling bandwidth is reduced.

I don't want anything for it keep it, like we would have done all along.

In love
Zozo the hellhound <3

@JSKitty JSKitty added the Enhancement New feature or request label Jan 31, 2023
@JSKitty JSKitty self-requested a review January 31, 2023 17:48
@JSKitty JSKitty linked an issue Jan 31, 2023 that may be closed by this pull request
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 tACK, successfully ran the deployment on my alt-repo.

This is appreciated, a reward is still on the table if you'd like, thank you for the help. 🙏

@ZOZOTHEHellhound
Copy link
Author

Well I guess I broke free of some restrains DCgg7RQ7tgG1HjYYq1uE4L6Ax5ErM9A9fk if you want. No need to do I really need to use this account from now on?❤️

@JSKitty
Copy link
Member

JSKitty commented Jan 31, 2023

do I really need to use this account from now on?

No need, you should have access again @11Tuvork28. 🙏

@JSKitty JSKitty requested review from Duddino and Liquid369 February 1, 2023 16:08
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 798b8f7

You beat me to it 🥇
I was just chaining the command, thanks for the fix!

@89Q12
Copy link

89Q12 commented Feb 2, 2023

You beat me to it 🥇 I was just chaining the command, thanks for the fix!

I saw it randomly because I was updating all services and just saw last image and was like what? Gotta fix that XD
Anyways cya around some time in the next PR if there ever is one until then happy to have fixed CI

@JSKitty
Copy link
Member

JSKitty commented Feb 2, 2023

The Docker whale comes back to life.

🐋

Just waiting on @Duddino 's review and we'll merge it right in.

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@JSKitty
Copy link
Member

JSKitty commented Feb 2, 2023

Merging, reward proposal here and governance tracking here.

@JSKitty JSKitty merged commit f75566b into PIVX-Labs:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Fix Docker image releases
5 participants