Add date-commit hash as a tag to images #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables better versioning and the ability for hoster to easily rollback a version
JSKitty
approved these changes
Feb 24, 2023
panleone
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Enables better versioning and the ability for maintainer of instances to easily rollback a version, as its good practice to version docker images too. Also relates to #55
What does this PR address?
Right now one can only choose:
ghcr.io/pivx-labs/mypivxwallet:latest
or
ghcr.io/pivx-labs/mypivxwallet:master
But what if latest goes bad? There is no way to automatically rollback without manually getting the last known good image digest.
What features or improvements were added?
With this change one can use e.g watchtower to automatically update to the next version tagged e.g
ghcr.io/pivx-labs/mypivxwallet:2023-02-19-223d6a4
If now
2023-02-20-313c5aggoes bad, an automatic rollback can be done.How does this benefit users?
Minimal down time for selfhosted/external hosted instances and better choosing of features one wants or don't.
It can also be used for easier debugging!