Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 'Transfer' design and small other changes #89

Merged
merged 23 commits into from
Mar 5, 2023
Merged

New 'Transfer' design and small other changes #89

merged 23 commits into from
Mar 5, 2023

Conversation

BreadJS
Copy link

@BreadJS BreadJS commented Feb 25, 2023

Abstract

I've changed the design of the sending page to make it more responsive, and have a cleaner UI.

What does this PR address?

MPW was not really responsive for other devices and lacks a good design (IMO). My intend is to redesign MPW for a better look and also make it as responsive as possible for every device.

What features or improvements were added?

  1. New Transfer
    • Menu animates from bottom to top when clicking on the Withdraw button
    • Simple design (removed the advanced features for now, they will be add back in a future PR)
    • Removed Send menu from navigation bar
  2. Other changes
    • Removing dotted outline on textboxes
    • Changed Dashboard height to remove empty space
    • Added an extra medium size button

How does this benefit users?

A better design will lure more users in using MPW. This also applies for making the site more responsive.

PIVX Address

DQnmBB6b6xLdjt2kqfgDWJGZGoMSATp1xS

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Transaction sent" alert only lasts for a very short amount of time, can you increase that?
Other than that I really like how the PR is progressing

JSKitty
JSKitty previously approved these changes Mar 3, 2023
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK - Brilliant design upgrade, HUGE enhancement to MPW usability, and starting from this PR, I believe it's now safe to consider MPW as "bare minimum READY" for mobile.

Let the mobile race begin. 🚀

Liquid369
Liquid369 previously approved these changes Mar 5, 2023
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK bb5bc50
To those following and concerned, the export private key is working here, so will be functional after merging
LGTM!

@JSKitty JSKitty dismissed stale reviews from Liquid369 and themself via fab2629 March 5, 2023 18:20
@Liquid369
Copy link

tACK

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final tACK via testnet.

@JSKitty JSKitty merged commit 61aaaeb into PIVX-Labs:master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants