Added ipv6 support to masternodes #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
reviewed
Feb 27, 2023
Duddino
force-pushed
the
masternodeipv6
branch
from
e8e4efd to
bd0aba1
Compare
panleone
approved these changes
Feb 28, 2023
JSKitty
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Add ipv6 support to masternodes.
The PR uses the convention to put square brackets around the IP and then add a colon and then the port.
For example [::1]:80 means address ::1, port 80. If the user doesn't provide a port, like with ipv4, the default port will be used
What does this PR address?
Masternodes were previously only available for ipv4 addresses
What features or improvements were added?
Masternodes can now be used with ipv6 addresses
How does this benefit users?
They can use ipv6 addresses to host their masternodes, which are usually cheaper