Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro, navbar & footer improvements #94

Merged
merged 3 commits into from
Mar 5, 2023
Merged

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Mar 3, 2023

Abstract

This small PR simply cleans up the navbar and footer slightly!

  • Navbar "Intro" button removed, MPW logo can now be clicked to see the Intro.
  • The "MPW Logo" easter-egg has been moved to the footer "made with 💜" text.
  • The Intro is now displayed at CSS-level, rather than needing a .click(), which also fixes the "blank page" issue upon a cacheless load of MPW.
  • The footer now has GitHub, Discord and Medium links with font-awesome icons.
  • Unnecessary residue i18n translations were removed.

image


image

What does this PR address?

It helps remove out current over-clutter of the navbar, as well as some page loading issues, and gives users better connectivity to PIVX Labs itself via additional footer links.

What features or improvements were added?

No new features, just general cleanup and fixes for an improved UX.

How does this benefit users?

Less UI clutter, slightly easier navigation, and less surprises when clicking the logo starts rapping at you!

@JSKitty JSKitty added the Enhancement New feature or request label Mar 3, 2023
@JSKitty JSKitty requested review from Liquid369, Duddino and BreadJS March 3, 2023 19:05
@JSKitty JSKitty self-assigned this Mar 3, 2023
@BreadJS
Copy link

BreadJS commented Mar 4, 2023

LGTM! 🤌🏻

Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 9ff8c26
Easter egg works, do not care about the rest!
Jokes, looks good.

@JSKitty JSKitty merged commit 79fa043 into master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants