Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Dev Insiders tend to ignore PRs from others, take the work and put it in their own PR #834
The few devs with write access to the PIVX repo appear to ignore pull requests from outsiders. Then a similar commit magically appears in their pull request and the one opened by the outsider is closed, with the insider commenting that it was fixed in another pull request and no credit is given to the outsider.
Expected result: Your commit gets merged and you are given credit.
Actual result: Commit is rewritten by Fuzzbawls, Warrows, Presstab, or Mrs. X, and they are credited with the commit. They say that what you fixed in your commit was already fixed in another PR. Refer to other PR. They close your PR and you feel like an idiot for helping as they fail to acknowledge that you did anything helpful at all.
Note: As evidenced by the current list of open PRs, you will almost never see a comment or acknowledgement on an outsider's pull request from a user with PIVX repo write access.
Alright, I'll try to go through your concerns. If you will allow me, here is what I understand:
If I may, I don't often see external devs reviewing neither "external" nor "core" devs PR. Maybe that would also boost the collaboration.
Wow, that was an excellent and we'll thought out answer with tons of info, especially considering the sarchastic/negative tone of my post. My past impressions (possibly incorrect) we're that you aren't very open to outside help.
But you are a true professional and I actually feel bad that I was so careless with what I said there. I was a little frustrated by a two line commit that's 18 days old without acknowledgement. It's fairly trivial to PIVX because the project isn't likely to encounter the condition that calls it again unless something changes, but it's obviously good practice to keep everything shiny. Nothing that needed immediate attention. There are basically two simple ways to fix it, but probably only one is correct.
I have noticed that, despite the exceedingly large number of projects that fork PIVX, there are very few that come back to contribute in a meaningful way, which is unfortunate and possibly really frustrating if I were on your side. I have reviewed a few of the teams commits and commented on them, but your coding skills are head and shoulders above mine and the average dev, so it's a little intimidating to do that. The chances of me catching mistakes with commits from the PIVX team are pretty slim. I do try to contribute with a fix here and there (first time with this account though) if I run into an issue - rather than just fixing it in my code, I think it's a dev's responsibility to bring that fix back to the original project, but I know that's pretty rare and it's unfortunate.
Anyway, I'm really impressed with your reply. A real class act compared to my snarky post. I apologise for that. I'll continue to contribute what I can. Thanks!