Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node] Replace IsSuperMajority with height checks #1067

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@Warrows
Copy link
Collaborator

Warrows commented Oct 29, 2019

BIP65 was enabled with block version 5. We now use block version 6 and are about to introduce version 7. It makes sense to save a bit of performance by simply checking for height activation instead of looking
for a super majority.

BIP65 was enabled with block version 5. We now use block version 6 and
are about to introduce version 7. It makes sense to save a bit of
performance by simply checking for height activation instead of looking
for a super majority.
@Warrows Warrows added the Validation label Oct 29, 2019
@Warrows Warrows self-assigned this Oct 29, 2019
Copy link
Collaborator

random-zebra left a comment

utACK 1490cdb

@random-zebra random-zebra added this to the 4.0.0 milestone Oct 29, 2019
@furszy
furszy approved these changes Oct 29, 2019
Copy link
Collaborator

furszy left a comment

utACK 1490cdb

src/main.cpp Show resolved Hide resolved
furszy added a commit that referenced this pull request Oct 31, 2019
1490cdb [Node] Replace IsSuperMajority with height checks (warrows)

Pull request description:

  BIP65 was enabled with block version 5. We now use block version 6 and are about to introduce version 7. It makes sense to save a bit of performance by simply checking for height activation instead of looking
  for a super majority.

ACKs for top commit:
  random-zebra:
    utACK 1490cdb
  furszy:
    utACK 1490cdb

Tree-SHA512: 8f253c9b5a5348e359950383ace380a8660d902b1f7b99bc2fc4cf6d8d96ae5b232bac309c6e03e2447f552bb016747157d65cce995972357a6466f616736743
@furszy furszy merged commit 1490cdb into PIVX-Project:master Oct 31, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Warrows Warrows deleted the Warrows:2019-10_perfs branch Oct 31, 2019
akshaynexus added a commit to VitaeTeam/Vitae-ReverseHF that referenced this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.