Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Decreasing the tooltip padding for #1076 windows issue. #1156

Merged
merged 2 commits into from Dec 4, 2019

Conversation

@furszy
Copy link
Collaborator

furszy commented Nov 28, 2019

Solving windows issue presented in #1076.

@furszy furszy self-assigned this Nov 28, 2019
Copy link
Collaborator

random-zebra left a comment

utACK ab1b5b4

@random-zebra random-zebra added the GUI label Nov 28, 2019
@random-zebra random-zebra added this to the 4.0.0 milestone Nov 28, 2019
@Warrows

This comment has been minimized.

Copy link
Collaborator

Warrows commented Nov 29, 2019

It's much better but not completely solved yet. There are still some cases where the display is not readable.

image

image

@furszy

This comment has been minimized.

Copy link
Collaborator Author

furszy commented Nov 29, 2019

Ok, pushed. The coin control address tooltip is not needed there, it's the exact same information.

Give another run pulling my latest commit.

@furszy furszy requested a review from Warrows Dec 1, 2019
@Warrows
Warrows approved these changes Dec 4, 2019
Copy link
Collaborator

Warrows left a comment

All good now, ACK da0ab95

Copy link
Collaborator

Fuzzbawls left a comment

utACK da0ab95

haven't done testing specifically on gitian-windows binaries, but linux/macOS native builds do not have any negative effects.

random-zebra added a commit that referenced this pull request Dec 4, 2019
…ssue.

da0ab95 [GUI] tooltip css changes. (furszy)
ab1b5b4 [GUI] Decreasing the tooltip padding for #1076 windows issue. (furszy)

Pull request description:

  Solving windows issue presented in #1076.

ACKs for top commit:
  Warrows:
    All good now, ACK da0ab95
  Fuzzbawls:
    utACK da0ab95

Tree-SHA512: 94ad7ca5c7f18ffb60d3bcd1eab3a7a37e3069fcd8a72cd9c19cf0a791b8fd92ebb97899ec026dff69306bacde96716333081afeaddd140d804448878ec7e599
@random-zebra random-zebra merged commit da0ab95 into PIVX-Project:master Dec 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
akshaynexus added a commit to VitaeTeam/Vitae-ReverseHF that referenced this pull request Dec 4, 2019
…X-Project#1076 windows issue.

da0ab95 [GUI] tooltip css changes. (furszy)
ab1b5b4 [GUI] Decreasing the tooltip padding for PIVX-Project#1076 windows issue. (furszy)

Pull request description:

  Solving windows issue presented in PIVX-Project#1076.

ACKs for top commit:
  Warrows:
    All good now, ACK da0ab95
  Fuzzbawls:
    utACK da0ab95

Tree-SHA512: 94ad7ca5c7f18ffb60d3bcd1eab3a7a37e3069fcd8a72cd9c19cf0a791b8fd92ebb97899ec026dff69306bacde96716333081afeaddd140d804448878ec7e599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.