[WIP][GUI] New double amount transaction row. #1275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New transaction record contemplating the following scenario: coin-owner transferring ownership to external wallet and receiving the delegation contract to hot stake. So.. there are at least 2 utxo and 3 utxo if there is a change utxo. The two amounts are: 1) The outgoing amount: delegated amount + change + fee. ---> showed in red. 2) The incoming delegation contract: delegated to myself amount. ---> showed in gray (for now).
|
Closing this PR, not on the current GUI records structure path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from #1270 issue, in which a special type of cold staking contract transaction is not presented in the best possible way in the GUI.
The PR adds a new transaction type and change the transaction row in the GUI + modifies the transaction record flow to support the special transaction.
The new transaction record is contemplating the following scenario:
coin-owner transferring ownership to external wallet and receiving the delegation contract to hot stake.
So.. there are at least 2 utxo, and 3 utxo if there is a change utxo. The two amounts are:
The outgoing amount: delegated amount + change + fee. ---> showed in red.
The incoming delegation contract: delegated to myself amount. ---> showed in gray (for now).
TODO:
Will not rush here to include it in 4.0.2, have been speaking with @random-zebra and most likely there are other scenarios that need the same treatment.