Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] One-click export to file #1424

Merged

Conversation

random-zebra
Copy link

Export to file directly, after selecting the destination and clicking "Save", without requiring additional button presses.
Interested flows:

  • backup wallet
  • export txes to csv
  • export addresses to csv

Closes #1417

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, just a connect() syntax change

src/qt/pivx/settings/settingsexportcsv.cpp Outdated Show resolved Hide resolved
src/qt/pivx/settings/settingsexportcsv.cpp Outdated Show resolved Hide resolved
@random-zebra
Copy link
Author

Rebased.

Fuzzbawls
Fuzzbawls previously approved these changes Mar 24, 2020
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 584419a

@random-zebra
Copy link
Author

Removed un-needed signal/slot connection in SettingsExportCSV.

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2df5e68

@random-zebra random-zebra merged commit 592aa52 into PIVX-Project:master Mar 28, 2020
akshaynexus added a commit to ZENZO-Ecosystem/ZENZO-Core that referenced this pull request Mar 30, 2020
2df5e68 [GUI] One-click export accounting (random-zebra)
a3edc53 [GUI] One-click wallet file backup (random-zebra)

Pull request description:

  Export to file directly, after selecting the destination and clicking "Save", without requiring additional button presses.
  Interested flows:
  - backup wallet
  - export txes to csv
  - export addresses to csv

  Closes PIVX-Project#1417

ACKs for top commit:
  furszy:
    ACK 2df5e68

Tree-SHA512: 96da02d48d65f5a16dc0649f9560a59cdf8e4b5f4bd2a98e8380bbdd5db24b35a8f0ed990315d1338ea85f39bcdae18c0ab8a4539a08e362b4b347783c5984a9
@random-zebra random-zebra deleted the 2020_GUI_oneclick_backups branch September 24, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Removal of unncessary extra mouse-click while creating wallet backup
3 participants