Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Fix dashboard txs list blinking issue #1699

Merged
merged 1 commit into from Jun 24, 2020

Conversation

furszy
Copy link

@furszy furszy commented Jun 19, 2020

The batch processing mode of the QListView is the cause of the list blinking on every update.

Seems that internally, QT fires up a screen region update that it's not calculated properly when the batch mode is enabled. Forcing to update the whole view even when there is no visual change for the rows that are being shown.

So, have moved the layout mode back to SinglePass, it solves the issue for now. We should check in the future if this has been solved in a newer QT version.

@furszy furszy self-assigned this Jun 19, 2020
Copy link

@ambassador000 ambassador000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested, working as intended. No more blinking, also tested with syncing last 10 days.

@random-zebra random-zebra added this to the 4.2.0 milestone Jun 24, 2020
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5586339

@Fuzzbawls Fuzzbawls changed the title GUI: dashboard txs list blinking issue [GUI] Fix dashboard txs list blinking issue Jun 24, 2020
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5586339

@Fuzzbawls Fuzzbawls merged commit 9bba19c into PIVX-Project:master Jun 24, 2020
@furszy furszy deleted the 2020_gui_blinking_issue branch November 29, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants