Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet][Refactoring] wallet/init refactoring backports #1811

Merged

Conversation

random-zebra
Copy link

Adapts the following refactoring PRs:

furszy
furszy previously approved these changes Aug 18, 2020
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work zebra <3 , Code review ACK ae0054e.

Have written few comments but aside from the technical, really minor, details. Conceptually, would be better to move the wallet pre/post initialization related methods to a separate file (possible a tool/factory) and not include them inside the wallet class. Those have really nothing to do with the wallet object responsibilities (obviously not here, in a following work. This is perfect as is, it's a great step forward).

src/init.cpp Outdated Show resolved Hide resolved
src/init.cpp Outdated Show resolved Hide resolved
src/init.cpp Outdated Show resolved Hide resolved
src/wallet/walletdb.cpp Show resolved Hide resolved
@random-zebra
Copy link
Author

Rebased.

@random-zebra
Copy link
Author

Rebased.

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re ACK 7e71759

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7e71759

perpetual updating PIVX Core to BTC Core automation moved this from In Progress to Ready Aug 25, 2020
@random-zebra random-zebra merged commit e89e20e into PIVX-Project:master Aug 25, 2020
perpetual updating PIVX Core to BTC Core automation moved this from Ready to Done Aug 25, 2020
@random-zebra random-zebra modified the milestones: 5.0.0, 4.3.0 Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants