New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet][Refactoring] wallet/init refactoring backports #1811
[Wallet][Refactoring] wallet/init refactoring backports #1811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work zebra <3 , Code review ACK ae0054e.
Have written few comments but aside from the technical, really minor, details. Conceptually, would be better to move the wallet pre/post initialization related methods to a separate file (possible a tool/factory) and not include them inside the wallet class. Those have really nothing to do with the wallet object responsibilities (obviously not here, in a following work. This is perfect as is, it's a great step forward).
ae0054e
to
de79f65
Compare
Rebased. |
>> inspired by bitcoin/bitcoin@fc7c60d Include also zwallet initialization (to be removed after v5.0)
>> adapted from bitcoin/bitcoin@25340b7
de79f65
to
7e71759
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re ACK 7e71759
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7e71759
Adapts the following refactoring PRs: