New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Count pending zPiv balance for automint. #282

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
4 participants
@presstab
Collaborator

presstab commented Oct 18, 2017

Auto mint was not accounting for non-mature zPiv mints.

@Fuzzbawls Fuzzbawls added the Minting label Oct 18, 2017

@Fuzzbawls Fuzzbawls added this to the 3.0.1 milestone Oct 18, 2017

@jonspock

This comment has been minimized.

Show comment
Hide comment
@jonspock

jonspock commented Oct 18, 2017

utACK

@Fuzzbawls Fuzzbawls changed the title from Count pending zPiv balance for automint. to [Wallet] Count pending zPiv balance for automint. Oct 18, 2017

@presstab presstab merged commit d13c280 into PIVX-Project:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

presstab added a commit that referenced this pull request Oct 18, 2017

Merge #282: [Wallet] Count pending zPiv balance for automint.
d13c280 Count pending zPiv balance for automint. (presstab)

Tree-SHA512: 49043d779da383e6c3bab8d03e788ecf67d34beef3a98a719263780b93a751df55421ccf28359e3d8bccaaa232dfcfd74c765e63c46619b7fc46022bf5574114
@Warrows

I was reading through the changes and noticed something surprising. I am not really familiar with the code but let have someone check this.

@@ -3443,7 +3448,7 @@ void CWallet::AutoZeromint()
return;
}
CAmount nZerocoinBalance = GetZerocoinBalance();
CAmount nZerocoinBalance = GetPendingZerocoinBalance();

This comment has been minimized.

@Warrows

Warrows Oct 18, 2017

Collaborator

Shouldn't this be
CAmount nZerocoinBalance = GetZerocoinBalance(false);
Or else we are going to compute the percentage of minting zerocoin instead of minted + minting (while before it was only minted).

@Warrows

Warrows Oct 18, 2017

Collaborator

Shouldn't this be
CAmount nZerocoinBalance = GetZerocoinBalance(false);
Or else we are going to compute the percentage of minting zerocoin instead of minted + minting (while before it was only minted).

This comment has been minimized.

@presstab

presstab Oct 18, 2017

Collaborator

Yes, you are definitely correct. Great catch, and thank you very much!

@presstab

presstab Oct 18, 2017

Collaborator

Yes, you are definitely correct. Great catch, and thank you very much!

This comment has been minimized.

@Warrows

Warrows Oct 18, 2017

Collaborator

You are welcome. Be careful, there might be the same thing a few lines down.

@Warrows

Warrows Oct 18, 2017

Collaborator

You are welcome. Be careful, there might be the same thing a few lines down.

@Fuzzbawls Fuzzbawls added this to Completed in libzerocoin Integration Oct 25, 2017

@presstab presstab deleted the presstab:fix_overmint branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment