Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] Remove vfReachable and modify IsReachable to only use vfLimited. #542

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
4 participants
@Warrows
Copy link
Collaborator

commented Feb 11, 2018

I was looking for the problem with #373. Turns out it's a network issue where reachability was not properly assessed and it's been fixed upstream in bitcoin and dash. So that's a simple backport of bitcoin/bitcoin@110b62f to fix #373 .

@Warrows Warrows added this to the 3.1.0 milestone Feb 11, 2018

@ghost ghost assigned Warrows Feb 11, 2018

@ghost ghost added review and removed Bug labels Feb 11, 2018

@Warrows Warrows changed the title Remove vfReachable and modify IsReachable to only use vfLimited. [Network] Remove vfReachable and modify IsReachable to only use vfLimited. Feb 11, 2018

Remove vfReachable and modify IsReachable to only use vfLimited.
This is a backport from bitcoin commit 110b62f
This should fix issue 373 and prevent some future net related issues
Original comment:
We do not know that a class of Network is reachable, only that it is not.

@Warrows Warrows force-pushed the Warrows:fix_373 branch to 38ed737 Feb 11, 2018

@Mrs-X

This comment has been minimized.

Copy link
Collaborator

commented Feb 11, 2018

It's not a Bitcoin commit you've linked to, but found it anyway :-)

Looks pretty straightforward, but I can't test the TOR part of it (I don't use Tor).
But I'll test if it works for other networks.

utACK 38ed737
Will test later...

@Mrs-X

Mrs-X approved these changes Feb 11, 2018

Copy link
Collaborator

left a comment

Tested and it indeed fixes #373 👍

One issue less on my ToDo list, thanks :-)

ACK 38ed737

@Fuzzbawls Fuzzbawls added P2P and removed P2P labels Feb 11, 2018

@Mrs-X

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2018

Since this is a known-to-work change from upstream and we don't have any TOR masternodes on testnet I'll merge it without dedicated TOR-tests.

@Mrs-X Mrs-X merged commit 38ed737 into PIVX-Project:master Feb 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mrs-X added a commit that referenced this pull request Feb 12, 2018

Merge #542: [Network] Remove vfReachable and modify IsReachable to on…
…ly use vfLimited.

38ed737 Remove vfReachable and modify IsReachable to only use vfLimited. (Patrick Strateman)

Tree-SHA512: 8aa61f9abd8356522f3ba71b35497aac07e10333a39ff4b98bb635d1246e6b1be6b0ee0b236944fbfaa558af0e6c0cc219e540eacb2232bc05db393e4a72b088

@ghost ghost removed the review label Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.