Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix chain ordering in budget tests #595

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
4 participants
@Fuzzbawls
Copy link
Collaborator

Fuzzbawls commented May 3, 2018

check testnet params first, then check mainnet so as to not interfere
with subsequent unit tests that rely on mainnet params.

Also clean up include ordering.

[Tests] Fix chain ordering in budget tests
check testnet params first, then check mainnet so as to not interfere
with subsequent unit tests that rely on mainnet params.

Also clean up include ordering.

@Fuzzbawls Fuzzbawls added the Tests label May 3, 2018

@wafflebot wafflebot bot added the review label May 3, 2018

@random-zebra
Copy link
Collaborator

random-zebra left a comment

ACK

@presstab

This comment has been minimized.

Copy link
Collaborator

presstab commented May 3, 2018

utACK

@Mrs-X

Mrs-X approved these changes May 3, 2018

Copy link
Collaborator

Mrs-X left a comment

Travis built okay, so ACK and merging...

@Mrs-X Mrs-X merged commit 3a6b152 into PIVX-Project:master May 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mrs-X added a commit that referenced this pull request May 3, 2018

Merge #595: [Tests] Fix chain ordering in budget tests
3a6b152 [Tests] Fix chain ordering in budget tests (Fuzzbawls)

Tree-SHA512: c94c7511d088bffc9568045b48b5fac8f10cceb4561e1d3a58fda3cb64227aee163280e9ad553157b206bd36257f516c34c697e8df4eeea153ffc8a44753a17a

@wafflebot wafflebot bot removed the review label May 3, 2018

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

[Tests] Fix chain ordering in budget tests
check testnet params first, then check mainnet so as to not interfere
with subsequent unit tests that rely on mainnet params.

Also clean up include ordering.

Github-Pull: PIVX-Project#595
Rebased-From: 3a6b152

@Fuzzbawls Fuzzbawls added this to the 3.1.1 milestone Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.