Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Fix spending for v1 zPIV created before block 1050020. #603

Merged
merged 3 commits into from May 10, 2018

Conversation

Projects
None yet
6 participants
@presstab
Copy link
Collaborator

presstab commented May 9, 2018

The transition to v2 zPIV and reset of the accumulators caused blocks 1050000 - 1050010 to be accumulated twice. This was causing many v1 zPIV to not create valid witnesses. This problem is fixed by double accumulating blocks 1050000-1050010 when creating the witness.

presstab added some commits May 9, 2018

Fix spending for v1 zPIV created before block 1050020.
The transition to v2 zPIV and reset of the accumulators caused blocks 1050000 - 1050010 to be accumulated twice. This was causing many v1 zPIV to not create valid witnesses. This problem is fixed by double accumulating blocks 1050000-1050010 when creating the witness.
Add getaccumulatorvalues RPC.
Return the accumulator values associated with a particular block height.

@wafflebot wafflebot bot added review and removed Bug labels May 9, 2018

@PIVX-Project

This comment has been minimized.

Copy link
Owner

PIVX-Project commented May 10, 2018

utACK

@Warrows
Copy link
Collaborator

Warrows left a comment

utACK

@DJstone

This comment has been minimized.

Copy link

DJstone commented May 10, 2018

Tested and works for me.
Further information:
Converted all my early version 1 zPIV to PIV and back to version 2 zPIV.
No Issues!

@Mrs-X

Mrs-X approved these changes May 10, 2018

Copy link
Collaborator

Mrs-X left a comment

I would have preferred constants over numbers, but since I can't test it anyway and someone with this issue successfully tested it I'll give it an utACK and merge it.

@Mrs-X Mrs-X merged commit ccf6c77 into PIVX-Project:master May 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mrs-X added a commit that referenced this pull request May 10, 2018

Merge #603: Fix spending for v1 zPIV created before block 1050020.
ccf6c77 Remove log spam and ensure proper zpiv version is used. (presstab)
8a6d425 Add getaccumulatorvalues RPC. (presstab)
abee3d9 Fix spending for v1 zPIV created before block 1050020. (presstab)

Tree-SHA512: cae09864f053c6a49ca696f4de6b3d8cbced37dc4d19ca8409b0bcc87a73520a31b3927f3b0522cc2c13d969062c55d4c2e8eab1c4fd138f44fdcdf2abd52413

@wafflebot wafflebot bot removed the review label May 10, 2018

@Fuzzbawls Fuzzbawls changed the title Fix spending for v1 zPIV created before block 1050020. [Wallet] Fix spending for v1 zPIV created before block 1050020. May 11, 2018

@Fuzzbawls Fuzzbawls added this to the 3.1.1 milestone Jun 28, 2018

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Fix spending for v1 zPIV created before block 1050020.
The transition to v2 zPIV and reset of the accumulators caused blocks 1050000 - 1050010 to be accumulated twice. This was causing many v1 zPIV to not create valid witnesses. This problem is fixed by double accumulating blocks 1050000-1050010 when creating the witness.

Github-Pull: PIVX-Project#603
Rebased-From: abee3d9

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Add getaccumulatorvalues RPC.
Return the accumulator values associated with a particular block height.

Github-Pull: PIVX-Project#603
Rebased-From: 8a6d425

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.