Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Remove unnecessary BOOST dependency #605

Merged
merged 1 commit into from May 11, 2018

Conversation

Projects
None yet
4 participants
@Mrs-X
Copy link
Collaborator

commented May 10, 2018

When build with --enable-debug the linker complains about a missing boost::gregorian dependency which is not really needed.

This PR removes this dependency, because, as we all know, with each BOOST-dependency somewhere a Unicorn dies...

It also addresses #601
Thanks and kudos to @FornaxA for finding the problem!

@Warrows
Copy link
Collaborator

left a comment

utACK

@Mrs-X

This comment has been minimized.

Copy link
Collaborator Author

commented May 11, 2018

Working with it for a whole day without problems (it's trivial anyway), so I'll merge it...

@Mrs-X Mrs-X merged commit da3a6a5 into PIVX-Project:master May 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mrs-X added a commit that referenced this pull request May 11, 2018

Merge #605: [Build] Remove unnecessary BOOST dependency
da3a6a5 [Build] Remove unnecessary BOOST dependency (Mrs-X)

Tree-SHA512: 633cafabc7cdf8a92d581bd28b4e55816e7f1a7a6ebe50321114a2add15c9d628677f51fb6403f531eb7153b80c7e9cade5cd158f720eaa8a7917dbc4ec64ff8

@wafflebot wafflebot bot removed the review label May 11, 2018

@FornaxA

This comment has been minimized.

Copy link

commented May 16, 2018

Makes much sense, nice.

@Fuzzbawls Fuzzbawls added this to the 3.1.1 milestone Jun 28, 2018

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.