Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Budget] Make sorting of finalized budgets deterministic #608

Merged
merged 1 commit into from May 12, 2018

Conversation

Projects
None yet
3 participants
@Mrs-X
Copy link
Collaborator

commented May 11, 2018

When there are 2 (or more) finalized(!) budgets (that's a valid condition) and both have the same voting count it's not deterministic which one is used to pay the monthly budgets and the network might not agree on a payment at all.

The worst possible result of this race-condition is that the network gets stuck one block before the budgets payments start, because one half of the network rejects the budgets payments of the other half.

This PR makes sorting and therefore the selection of the finalized budget deterministic and avoids this scenario.

@wafflebot wafflebot bot added the review label May 11, 2018

@Warrows
Copy link
Collaborator

left a comment

utACK

@Mrs-X

This comment has been minimized.

Copy link
Collaborator Author

commented May 12, 2018

I'll merge this one because I need it to test another PR...

@Mrs-X Mrs-X merged commit 93e637f into PIVX-Project:master May 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mrs-X added a commit that referenced this pull request May 12, 2018

Merge #608: [Budget] Make sorting of finalized budgets deterministic
93e637f [Budget] Make sorting of finalized budgets deterministic (Mrs-X)

Tree-SHA512: f5a3757b79d18eaef859face1f1ba894bf393aae5ddb0a916d8b3f782baac73f82bf76bc8844e2802352bdf9d4ea1a65785de67507433f95eb7c008884adf68b

@wafflebot wafflebot bot removed the review label May 12, 2018

@Fuzzbawls Fuzzbawls added this to the 3.1.1 milestone Jun 28, 2018

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.