Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main] Check whether tx is in chain in ContextualCheckZerocoinMint(). #610

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
3 participants
@presstab
Copy link
Collaborator

presstab commented May 11, 2018

This fixes issues that certain wallets have had with reorgs where the new blocks are rejected because the mint in the zerocoindb was not properly purged.

@wafflebot wafflebot bot added the review label May 11, 2018

@Fuzzbawls

This comment has been minimized.

Copy link
Collaborator

Fuzzbawls commented May 11, 2018

ACK c4141aa

Small note however: wallets that already have a block marked as invalid will need to use reconsiderblock to have it checked again.

@Fuzzbawls Fuzzbawls changed the title Check whether tx is in chain in ContextualCheckZerocoinMint(). [Main] Check whether tx is in chain in ContextualCheckZerocoinMint(). May 12, 2018

@Warrows
Copy link
Collaborator

Warrows left a comment

utACK

@presstab presstab added zPiv and removed UTXO DBs and Indexes labels May 13, 2018

@presstab presstab merged commit c4141aa into PIVX-Project:master May 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

presstab added a commit that referenced this pull request May 14, 2018

Merge #610: [Main] Check whether tx is in chain in ContextualCheckZer…
…ocoinMint().

c4141aa Check whether tx is in chain in ContextualCheckZerocoinMint(). (presstab)

Tree-SHA512: 6536bb9b49ae8548b8ce4840df87a0d1384b50bfca669eedffd541838345c476e166a62aa89d4022e306822bb2063bc9e509347fdd366aaa1a9a62e434b84e35

@wafflebot wafflebot bot removed the review label May 14, 2018

@@ -1245,7 +1245,8 @@ bool ContextualCheckZerocoinMint(const CTransaction& tx, const PublicCoin& coin,
if (pindex->nHeight >= Params().Zerocoin_Block_V2_Start() && Params().NetworkID() != CBaseChainParams::TESTNET) {
//See if this coin has already been added to the blockchain
uint256 txid;
if(zerocoinDB->ReadCoinMint(coin.getValue(), txid))
int nHeight;

This comment has been minimized.

Copy link
@Warrows

Warrows Jun 20, 2018

Collaborator

Shouldn't nHeight be given a value here?

@Warrows Warrows referenced this pull request Jun 23, 2018

Closed

PIVX banning peers #604

@Fuzzbawls Fuzzbawls added this to the 3.1.1 milestone Jun 28, 2018

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.