Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Adjust staking properties to lower orphan rates. #617

Merged
merged 2 commits into from May 26, 2018

Conversation

Projects
None yet
5 participants
@presstab
Copy link
Collaborator

presstab commented May 15, 2018

No description provided.

presstab added some commits May 15, 2018

Lower stake hashdrift to 30 seconds.
Lower the hash drift which should reduce the amount of orphans.

@wafflebot wafflebot bot added the review label May 15, 2018

@PIVX-Project

This comment has been minimized.

Copy link
Owner

PIVX-Project commented May 17, 2018

ACK

@Warrows
Copy link
Collaborator

Warrows left a comment

ACK. Looks good and nothing seems broken. I'm not able to say if I'm getting less orphans though.

//Only update zPIV set once per update interval
bool fUpdate = false;
static int64_t nTimeLastUpdate = 0;
if (GetAdjustedTime() - nTimeLastUpdate > nStakeSetUpdateTime) {

This comment has been minimized.

Copy link
@Warrows

Warrows May 25, 2018

Collaborator

Going from GetTime() to GetAdjustedTime() might be a real good change for some users.

@Mrs-X

Mrs-X approved these changes May 26, 2018

Copy link
Collaborator

Mrs-X left a comment

Didn't notice any difference at all, but, ACK.
And merging...

@Mrs-X Mrs-X merged commit 4c862f2 into PIVX-Project:master May 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mrs-X added a commit that referenced this pull request May 26, 2018

Merge #617: [Wallet] Adjust staking properties to lower orphan rates.
4c862f2 Lower stake hashdrift to 30 seconds. (presstab)
355e2d3 Update zPIV stake set more frequently. (presstab)

Tree-SHA512: fcbfeb23bdf5e84c38d64780b97cd0a3f6d7ecb630b2b2e7ba13daf2538d691409be70d889b418b3165c79c0ec0bcc8080dd1aec072d559bf77b1e9093af75e7

@wafflebot wafflebot bot removed the review label May 26, 2018

@Fuzzbawls Fuzzbawls added this to the 3.1.1 milestone Jun 28, 2018

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Lower stake hashdrift to 30 seconds.
Lower the hash drift which should reduce the amount of orphans.

Github-Pull: PIVX-Project#617
Rebased-From: 4c862f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.