Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Remove useless help button from QT dialogs (windows) #629

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
2 participants
@Warrows
Copy link
Collaborator

Warrows commented Jun 5, 2018

Fix #614.

@wafflebot wafflebot bot added the review label Jun 5, 2018

@Warrows Warrows changed the title [UI] Remove useless help button from QT dialogs [Qt] Remove useless help button from QT dialogs Jun 6, 2018

@Fuzzbawls

This comment has been minimized.

Copy link
Collaborator

Fuzzbawls commented Jun 9, 2018

just wondering; which OSes does this affect? The useless help button is non-existent on macs currently.

either way, there is no need for an OS generated button that isn't used, so Concept ACK.

@Warrows

This comment has been minimized.

Copy link
Collaborator Author

Warrows commented Jun 9, 2018

I guess it's windows only like @Mrs-X said in the issue discussion.

@Fuzzbawls

This comment has been minimized.

Copy link
Collaborator

Fuzzbawls commented Jun 9, 2018

yeah, saw that after commenting...

maybe the PR title should be changed to "Fix useless windows OS from being so useless" ;)

@Warrows Warrows changed the title [Qt] Remove useless help button from QT dialogs [Qt] Remove useless help button from QT dialogs (windows) Jun 11, 2018

@Fuzzbawls

This comment has been minimized.

Copy link
Collaborator

Fuzzbawls commented Jun 19, 2018

ACK 4dc636c

will merge this soon

@Fuzzbawls Fuzzbawls merged commit 4dc636c into PIVX-Project:master Jun 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Fuzzbawls added a commit that referenced this pull request Jun 19, 2018

Merge #629: [Qt] Remove useless help button from QT dialogs (windows)
4dc636c [UI] Remove useless help button from QT dialogs (warrows)

Tree-SHA512: 04f7d6a8d7c6560826aca0d19e5de91db4f5c1652f4faaece9772bc509203486965bfcc90c9431c1802f5a4fdc3a6478e2c8bda344b438a687f8544736a824ea

@wafflebot wafflebot bot removed the review label Jun 19, 2018

@Warrows Warrows deleted the Warrows:warrows_614 branch Jun 20, 2018

@Fuzzbawls Fuzzbawls added this to the 3.1.1 milestone Jun 28, 2018

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.